KSparseBallLMO #268
Open
KSparseBallLMO #268
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… situations, so further improvements are needed.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #268 +/- ##
==========================================
- Coverage 86.23% 84.70% -1.53%
==========================================
Files 17 22 +5
Lines 1482 2753 +1271
==========================================
+ Hits 1278 2332 +1054
- Misses 204 421 +217 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Author
|
There is only DiamondLMO(L1) and KsparseLMO |
Contributor
Author
|
Now is only Ksparse |
dhendryc
requested changes
Dec 17, 2025
src/polytope_blmos.jl
Outdated
Comment on lines
731
to
734
| struct KSparseBLMO <: FrankWolfe.LinearMinimizationOracle | ||
| K::Int | ||
| right_hand_side::Float64 | ||
| end |
src/polytope_blmos.jl
Outdated
Comment on lines
736
to
744
| function bounded_compute_extreme_point( | ||
| lmo::KSparseBLMO, | ||
| direction, | ||
| lb, | ||
| ub, | ||
| int_vars; | ||
| v=nothing, | ||
| kwargs..., | ||
| ) |
Collaborator
There was a problem hiding this comment.
function bounded_compute_extreme_point(
lmo::FrankWolfe.KSparseLMO{T},
direction,
lb,
ub,
int_vars;
v=nothing,
kwargs...
)
..
end
|
|
||
| for i in 1:n_int | ||
| v = clamp(τ, lb[i], ub[i]) | ||
| if abs.(v) .> τ + tol |
Collaborator
There was a problem hiding this comment.
the broadcasting is not needed here since v is a scalar.
test/heuristics.jl
Outdated
Comment on lines
222
to
226
|
|
||
| n = 20 | ||
| sparsity = 0.3 | ||
| x_sol = [rand() < sparsity ? 0 : rand(1:floor(Int, n / 4)) for _ in 1:n] | ||
| n_int = 17 |
dhendryc
requested changes
Jan 8, 2026
src/polytope_blmos.jl
Outdated
Comment on lines
719
to
730
|
|
||
| """ | ||
| KSparseLMO{T}(K::Int, right_hand_side::T) | ||
| LMO for the K-sparse polytope: | ||
| ``` | ||
| C = B_1(τK) ∩ B_∞(τ) | ||
| ``` | ||
| with `τ` the `right_hand_side` parameter. | ||
| The LMO results in a vector with the K largest absolute values | ||
| of direction, taking values `-τ sign(x_i)`. | ||
| """ |
Collaborator
There was a problem hiding this comment.
Please add a description/sketch the idea of function,
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1.Extend the Polytope LMOs from FW to Boscia: KNormBallLMO, DiamondLMO (generalisation of the L1-norm ball), KSparseLMO
2.For the DiamondLMO, the L1 norm version is the only implemented,a diamond constraint can be inputed, but the result will most likely be incorrect because it implements L1 norm. haven't figured out how to implement a diamond constraint yet.